Conversation
- android-activity: rust-mobile/android-activity#200 - winit: damus-io/winit@eaff639 - egui: damus-io/egui@113922d Signed-off-by: William Casarin <jb55@jb55.com>
support multiline ime hints --------------------------- - android-activity: rust-mobile/android-activity#200 - winit: damus-io/winit@eaff639 - egui: damus-io/egui@113922d And many other fixes -------------------- Fixes: #894 Fixes: #895 Fixes: #893 Signed-off-by: William Casarin <jb55@jb55.com>
6338298 to
8db0d2b
Compare
|
@jb55 What is the status of this PR? (I see it is still marked as a draft). I believe that the ability to set the |
|
we're using it in https://github.com/damus-io/notedeck, i guess I can mark it as ready. |
|
Cool, thanks for looking at this. I've recently worked on exposing the editor actions via a TextAction event + fixing a panic that can come from soft keyboard visibility changes (due to APP_CMD_SOFTWARE_KB_VIS_CHANGED not being handled). With these I've also got IME support working with winit 0.30 + egui. Skimming this PR, I might just tweak the flags + bitmasks to be hex values since I find it a bit odd seeing these in decimal (just a pedantic personal preference I suppose) |
|
okey, sorry for the delay in getting around to look at this. I've moved the new input types to src/input.rs (along with other existing input types) and filled out the remaining
There is also a separate |
32d9911 to
71fa555
Compare
This corresponds to the GameActivity_setImeEditorInfo function on GameActivity. This is not supported on NativeActivity. Signed-off-by: William Casarin <jb55@jb55.com>
This adds and documents the remaining `ImeOptions` (addressing TODO comment) `ImeOptions` now has a getter/setter for the action, based on the `TextInputAction` enum added in rust-mobile#216 There is also a separate `InputTypeClass` that lets you query the mutually-exclusive type class bits from an `InputType`
Makes it possible to configure the action of the IME enter key via `set_ime_editor_info()`
|
For reference |
This builds on top of:
The commit in this PR is:
This adds support for
GameActivity_setImeEditorInfowhich is needed for setting various IME hints, such as multiline.I'm currently using this in my egui/winit fork for mapping a new Multiline ImePurpose to ime editor options:
This ensures that the enter action button doesn't close the keyboard, it instead enters a newline.